Skip to content

prompt: add some metrics to the new tui prompt#3469

Merged
nicks merged 1 commit into
masterfrom
nicks/ch7730
Jun 16, 2020
Merged

prompt: add some metrics to the new tui prompt#3469
nicks merged 1 commit into
masterfrom
nicks/ch7730

Conversation

@nicks

@nicks nicks commented Jun 16, 2020

Copy link
Copy Markdown
Contributor

Hello @landism, @victorwuky,

Please review the following commits I made in branch nicks/ch7730:

d960bb3 (2020-06-16 14:07:56 -0400)
prompt: add some metrics to the new tui prompt

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
nicks requested review from landism and wu-victor June 16, 2020 18:09
@nicks
nicks force-pushed the nicks/ch7730 branch 2 times, most recently from 6417c83 to 2f8dbb1 Compare June 16, 2020 18:13
@nicks

nicks commented Jun 16, 2020

Copy link
Copy Markdown
Contributor Author

New fields:
term_mode on tilt.cmd.up
term_mode on tilt.up.running

New metrics
tilt.ui.prompt.switch - switch terminal modes
tilt.ui.prompt.browser - open browser

New fields:
term_mode on tilt.cmd.up
term_mode on tilt.up.running

New metrics
tilt.ui.prompt.switch - switch terminal modes
tilt.ui.prompt.browser - open browser
@nicks
nicks merged commit 966d7bb into master Jun 16, 2020
@nicks
nicks deleted the nicks/ch7730 branch June 16, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants