Skip to content

local: fix shutdown sequence to handle delayed exit and log correctly#3480

Merged
nicks merged 1 commit into
masterfrom
nicks/ch7815/local
Jun 19, 2020
Merged

local: fix shutdown sequence to handle delayed exit and log correctly#3480
nicks merged 1 commit into
masterfrom
nicks/ch7815/local

Conversation

@nicks

@nicks nicks commented Jun 19, 2020

Copy link
Copy Markdown
Contributor

Hello @jazzdan, @landism,

Please review the following commits I made in branch nicks/ch7815/local:

257f34a (2020-06-19 10:08:33 -0400)
local: fix shutdown sequence to handle delayed exit and log correctly Fixes #3479 Fixes #3443

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
nicks requested review from jazzdan and landism June 19, 2020 14:09
@nicks
nicks force-pushed the nicks/ch7815/local branch from 257f34a to bc1b2f2 Compare June 19, 2020 14:11
@nicks
nicks merged commit 0d0f79b into master Jun 19, 2020
@nicks
nicks deleted the nicks/ch7815/local branch June 19, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

local_resource process shutdown does not work Local Process Logs Get Lost When Process is Killed

3 participants