ci: ci mode shouldnt wait for resources with auto_init=false [ch7838]#3485
Merged
Conversation
added 2 commits
June 19, 2020 13:06
nicks
approved these changes
Jun 19, 2020
| // If any of the resources are in error, exit. | ||
| allOK := true | ||
| for _, mt := range state.ManifestTargets { | ||
| // don't wait on resources requiring manual trigger for initial build |
Contributor
There was a problem hiding this comment.
it might make sense to have a unit test for this
Contributor
There was a problem hiding this comment.
(see the tests under controller_test.go)
landism
approved these changes
Jun 19, 2020
added 2 commits
June 19, 2020 17:15
This reverts commit 80482b9.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #3478
Not sure that an integration test is the best way to verify this behavior--
@nicks are there better structures already in the code for testing ci mode?