Skip to content

store: Use the NonWorkload field to determine runtime status#3527

Merged
nicks merged 1 commit into
masterfrom
nicks/ch8127
Jun 29, 2020
Merged

store: Use the NonWorkload field to determine runtime status#3527
nicks merged 1 commit into
masterfrom
nicks/ch8127

Conversation

@nicks

@nicks nicks commented Jun 29, 2020

Copy link
Copy Markdown
Contributor

Hello @jazzdan, @maiamcc,

Please review the following commits I made in branch nicks/ch8127:

869806b (2020-06-29 16:40:46 -0400)
store: Use the NonWorkload field to determine runtime status
This is a better indicator if a manifest has pods

Fixes #3497

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

This is a better indicator if a manifest has pods

Fixes #3497
@nicks
nicks requested review from jazzdan and maiamcc June 29, 2020 20:41
@nicks
nicks merged commit 16e1e74 into master Jun 29, 2020
@nicks
nicks deleted the nicks/ch8127 branch June 29, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot build resource_deps on renamed/grouped k8s_resources

2 participants