tilt logs: add port/resource flags, filter by resource [ch8432 ch8433]#3655
Merged
Conversation
nicks
reviewed
Aug 3, 2020
| if toCheckpoint > ls.checkpoint { | ||
| ls.checkpoint = toCheckpoint | ||
| if segsAdded > 0 { | ||
| ls.checkpointInternal += logstore.Checkpoint(segsAdded) |
Contributor
There was a problem hiding this comment.
shouldn't this be ls.logstore.Checkpoint(), like we do in TerminalStream?
no reason to be doing checkpoint arithmetic out here
|
|
||
| // TODO(maia): filter for the resources that we care about (`tilt logs resourceA resourceC`) | ||
| // --> and if there's only one resource, don't prefix logs with resource name? | ||
| // TODO(maia): if there's only one resource, don't prefix logs with resource name |
Contributor
There was a problem hiding this comment.
i wonder if it makes more sense to have an options object to ContinuingLines that takes a set of resources to filter on....we already do this internally with toLogLines logOptions (which filters on a set of spans)
Contributor
|
also - the PR description says it added port flags, but i couldn't find them? |
maiamcc
force-pushed
the
maiamcc/filter-resources
branch
from
August 6, 2020 20:02
857bdf0 to
3a7b455
Compare
Contributor
Author
jazzdan
approved these changes
Aug 6, 2020
| var alphabet = []string{"alpha", "bravo", "charlie", "delta", "echo", "foxtrot", | ||
| "golf", "hotel", "igloo", "juliette", "kilo", "lima", "mike", "november", | ||
| "oscar", "papa", "quebec", "romeo", "sierra", "tango", "uniform", "victor", | ||
| "whiskey", "xavier", "yankee", "zulu"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @nicks, @jazzdan,
Please review the following commits I made in branch maiamcc/filter-resources:
857bdf0 (2020-08-03 13:03:31 -0400)
tilt logs: add port/resource flags, filter by resource [ch8432 ch8433]
Code review reminders, by giving a LGTM you attest that: