tiltfile: add a stringable type to make it easier to unpack strings#3698
Merged
Conversation
landism
approved these changes
Aug 13, 2020
landism
left a comment
Member
There was a problem hiding this comment.
LGTM, definite improvement over status quo.
This highlights to me that we don't have much consistency about whether a function's string parameter has to be an actual string or simply a stringable. Think it'd make sense to have our unpacker swap out all strings with stringables before calling the starlark unpacker?
Contributor
Author
|
@landism ya, possibly! one thing I went back and forth on is if we should have a string Unpacker that trims the whitespace/newlines off blobs, or matches them against some validity regexp, or if that would be confusing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @maiamcc, @landism,
Please review the following commits I made in branch nicks/stringable:
0422a04 (2020-08-12 19:35:49 -0400)
tiltfile: add a stringable type to make it easier to unpack strings
Code review reminders, by giving a LGTM you attest that: