Skip to content

web: split SidebarItem into its own file#3825

Merged
nicks merged 1 commit into
masterfrom
nicks/sidebaritem
Oct 5, 2020
Merged

web: split SidebarItem into its own file#3825
nicks merged 1 commit into
masterfrom
nicks/sidebaritem

Conversation

@nicks

@nicks nicks commented Oct 2, 2020

Copy link
Copy Markdown
Contributor

Hello @hyu, @maiamcc,

Please review the following commits I made in branch nicks/sidebaritem:

0ecb7ec (2020-10-02 18:33:55 -0400)
web: split SidebarItem into its own file

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
nicks requested review from hyu and maiamcc October 2, 2020 22:36
@nicks
nicks force-pushed the nicks/sidebaritem branch from 0ecb7ec to c628391 Compare October 2, 2020 22:38

@maiamcc maiamcc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicks
nicks merged commit 71a19ed into master Oct 5, 2020
@nicks
nicks deleted the nicks/sidebaritem branch October 5, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants