Skip to content

webview: Tiltfile has no runtime status#3975

Merged
nicks merged 1 commit into
masterfrom
nicks/ch10422
Dec 11, 2020
Merged

webview: Tiltfile has no runtime status#3975
nicks merged 1 commit into
masterfrom
nicks/ch10422

Conversation

@nicks

@nicks nicks commented Dec 8, 2020

Copy link
Copy Markdown
Contributor

Hello @hyu,

Please review the following commits I made in branch nicks/ch10422:

b934afd (2020-12-08 13:16:11 -0500)
webview: Tiltfile has no runtime status

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
nicks requested a review from hyu December 8, 2020 18:16
@nicks

nicks commented Dec 8, 2020

Copy link
Copy Markdown
Contributor Author

this turned out to be easier than i expected 😁

@nicks
nicks merged commit 7a9fdff into master Dec 11, 2020
@nicks
nicks deleted the nicks/ch10422 branch December 11, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants