Skip to content

web: add sidebar item textures#3978

Merged
nicks merged 1 commit into
masterfrom
nicks/ch10436
Dec 10, 2020
Merged

web: add sidebar item textures#3978
nicks merged 1 commit into
masterfrom
nicks/ch10436

Conversation

@nicks

@nicks nicks commented Dec 8, 2020

Copy link
Copy Markdown
Contributor

Hello @hyu,

Please review the following commits I made in branch nicks/ch10436:

4f8d164 (2020-12-08 18:47:33 -0500)
web: add sidebar item textures

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
nicks requested a review from hyu December 8, 2020 23:47
@nicks

nicks commented Dec 8, 2020

Copy link
Copy Markdown
Contributor Author

cc @SurbhiSGupta

Screenshot from 2020-12-08 18-48-04
Screenshot from 2020-12-08 18-47-54

i needed to add some new colors to the color scale, but made sure they're change-able so we can adjust them later

@nicks

nicks commented Dec 10, 2020

Copy link
Copy Markdown
Contributor Author

hold off, going to replace w/ the icons we talked about

@nicks

nicks commented Dec 10, 2020

Copy link
Copy Markdown
Contributor Author

Screenshot from 2020-12-10 11-41-24
Screenshot from 2020-12-10 11-41-08

@nicks

nicks commented Dec 10, 2020

Copy link
Copy Markdown
Contributor Author

updated!

@nicks
nicks force-pushed the nicks/ch10436 branch 3 times, most recently from 7774f2f to 5e0e7aa Compare December 10, 2020 16:45

@hyu hyu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ⚠️

@nicks
nicks merged commit 658f271 into master Dec 10, 2020
@nicks
nicks deleted the nicks/ch10436 branch December 10, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants