Skip to content

web: scaffolding for OverviewResourcePane#3989

Merged
nicks merged 1 commit into
masterfrom
nicks/ch10469
Dec 14, 2020
Merged

web: scaffolding for OverviewResourcePane#3989
nicks merged 1 commit into
masterfrom
nicks/ch10469

Conversation

@nicks

@nicks nicks commented Dec 11, 2020

Copy link
Copy Markdown
Contributor

Hello @hyu,

Please review the following commits I made in branch nicks/ch10469:

a1885b8 (2020-12-11 09:59:16 -0500)
web: scaffolding for OverviewResourcePane

3f06807 (2020-12-11 09:59:16 -0500)
web: add scaffolding for the OverviewPane

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
nicks requested a review from hyu December 11, 2020 15:02
@nicks

nicks commented Dec 11, 2020

Copy link
Copy Markdown
Contributor Author

Screenshot from 2020-12-11 10-01-57

again, just setting up storybooks with dummy data and can start filling components into the boxes

@nicks

nicks commented Dec 14, 2020

Copy link
Copy Markdown
Contributor Author

going to merge this one too, since it's just scaffolding

@nicks
nicks merged commit 6f7d8c3 into master Dec 14, 2020
@nicks
nicks deleted the nicks/ch10469 branch December 14, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant