Skip to content

web: Use contexts to provide PathBuilder#4030

Merged
nicks merged 1 commit into
masterfrom
nicks/pathbuilder
Dec 24, 2020
Merged

web: Use contexts to provide PathBuilder#4030
nicks merged 1 commit into
masterfrom
nicks/pathbuilder

Conversation

@nicks

@nicks nicks commented Dec 22, 2020

Copy link
Copy Markdown
Contributor

Hello @landism, @hyu,

Please review the following commits I made in branch nicks/pathbuilder:

9d0bd0e (2020-12-22 12:01:18 -0500)
web: Use contexts to provide PathBuilder

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
nicks requested review from hyu and landism December 22, 2020 17:02
@nicks

nicks commented Dec 22, 2020

Copy link
Copy Markdown
Contributor Author

i like this pattern! this will make things a bit simpler i think

@nicks
nicks force-pushed the nicks/pathbuilder branch from 9d0bd0e to 2b50abf Compare December 22, 2020 17:33

@landism landism left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicks
nicks merged commit 95698e6 into master Dec 24, 2020
@nicks
nicks deleted the nicks/pathbuilder branch December 24, 2020 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants