ui: tests for test section of overview pane#4083
Merged
Merged
Conversation
maiamcc
marked this pull request as draft
January 15, 2021 17:30
Contributor
Author
|
Oh wait let me make the error reporting a little better |
maiamcc
marked this pull request as ready for review
January 15, 2021 17:40
Contributor
Author
|
...never mind, there's no clean way to do this, this level of verbosity in test output is fine--a user can go back through the stack trace to find where things went wrong if they need to :-/ |
nicks
reviewed
Jan 15, 2021
| <ServicesLabel>Pinned Resources</ServicesLabel> | ||
| </ServicesDividerRoot> | ||
| ) | ||
| function PinnedResources(items: OverviewItem[]) { |
Contributor
There was a problem hiding this comment.
can you make these React components that return React.Fragments?
| ) | ||
| function PinnedResources(items: OverviewItem[]) { | ||
| return items?.length ? ( | ||
| <div className={"resources-container pinned"}> |
Contributor
There was a problem hiding this comment.
Let's get rid of all the CSS class names in this PR. None of them are used for styling. Once this is a React.Fragment, you should be able to use the react component itself as a selector.
Contributor
Author
|
thanks for the tip -- this should be better! |
nicks
approved these changes
Jan 15, 2021
| export function PinnedResources(props: ResourceProps) { | ||
| return props.items?.length ? ( | ||
| <React.Fragment> | ||
| <ServicesDividerRoot className={"ServicesDivider pinned"}> |
Contributor
There was a problem hiding this comment.
you should be able to get rid of these classes too now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @nicks, @hyu,
Please review the following commits I made in branch maiamcc/test-section-tests:
5c6b5ed (2021-01-15 12:29:33 -0500)
ui: tests for test section of overview pane
Code review reminders, by giving a LGTM you attest that: