tiltfile: add readiness probe support for local_resource#4112
Merged
Conversation
Syntax is adapted from K8s probe spec to Starlark semantics (e.g. `snake_case` vs `camelCase` for names).
landism
reviewed
Jan 25, 2021
milas
marked this pull request as draft
January 25, 2021 22:49
milas
force-pushed
the
milas/tiltfile-local-probe
branch
from
January 26, 2021 17:27
eed4578 to
9e0adfe
Compare
milas
marked this pull request as ready for review
January 26, 2021 17:31
milas
added a commit
to tilt-dev/tilt.build
that referenced
this pull request
Jan 27, 2021
See tilt-dev/tilt#4112 for corresponding Tiltfile implementation.
landism
approved these changes
Jan 27, 2021
milas
added a commit
to tilt-dev/tilt.build
that referenced
this pull request
Jan 29, 2021
See tilt-dev/tilt#4112 for corresponding Tiltfile implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness checks for local resources - see #3109 and tilt-dev/tilt.specs : readiness_probe.md for context.
Syntax is adapted from K8s probe spec to Starlark semantics (e.g.
snake_casevscamelCasefor names).This is just the
Tiltfilewiring, the engine logic to make use of it is in #4102 (will be merged after this so that it can include these changes enabling integration tests).