web: change Sidebar tab semantics#4116
Conversation
|
This pull request has been linked to Clubhouse Story #10949: In Sidebar, if you click on a resource with an open tab, go to that tab. |
| // it opens a new tab, and brings the new tab into focus. | ||
| // 2) Otherwise, when you select a resource on the left sidebar, | ||
| // a) click opens it in the current tab, | ||
| // b) ctrl-click opens it in a new tab on the immediate right of current tab |
There was a problem hiding this comment.
Not part of this PR, but I noticed during review:
For me on Firefox, the Mac OS context menu still has precedence. I assume the expected behavior is that Tilt should hijack?
(Maybe I'm missing something. You're able to override the context menu on Mac?)
There was a problem hiding this comment.
yep, on macos it's the command key
fwiw, most of the standards docs on this tend to be super vague and hand-wavey for exactly the reason you describe - this tends to be dictated by a complicated set of overlapping OS-level preferences and browser-level preferences, so i changed this comment to be more hand-wavey
now, we never change the number of tabs open if the selected resource is already open
3 participants
Hello @hyu, @landism,
Please review the following commits I made in branch nicks/ch10949:
0415af8 (2021-01-25 11:50:45 -0500)
web: change Sidebar tab semantics
now, we never change the number of tabs open if the selected resource is already open
Code review reminders, by giving a LGTM you attest that: