Skip to content

cli: add 'tilt alpha updog', a command to experiment with the new api#4328

Merged
nicks merged 1 commit into
masterfrom
nicks/updog
Mar 17, 2021
Merged

cli: add 'tilt alpha updog', a command to experiment with the new api#4328
nicks merged 1 commit into
masterfrom
nicks/updog

Conversation

@nicks

@nicks nicks commented Mar 16, 2021

Copy link
Copy Markdown
Contributor

Hello @milas, @maiamcc,

Please review the following commits I made in branch nicks/updog:

36177fc (2021-03-16 18:59:18 -0400)
cli: add 'tilt alpha updog', a command to experiment with the new api

a3585fc (2021-03-16 18:01:57 -0400)
fix

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
nicks requested review from maiamcc and milas March 16, 2021 22:59
@nicks

nicks commented Mar 16, 2021

Copy link
Copy Markdown
Contributor Author

Most of this PR is boilerplate from 'tilt up' and 'tilt ci'

@maiamcc maiamcc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's updog?

Comment thread internal/cli/updog.go Outdated

log.SetFlags(log.Flags() &^ (log.Ldate | log.Ltime))

// Force wev-mode to prod

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Force wev-mode to prod
// Force web-mode to prod

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread internal/cli/updog.go Outdated
func (c *updogCmd) register() *cobra.Command {
cmd := &cobra.Command{
Use: "updog",
Short: "Runs the Tilt apiserver, applies the config, and streams logs until ctrl-c",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe short doc should mention that this is a dummy app?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@nicks
nicks merged commit 8622600 into master Mar 17, 2021
@nicks
nicks deleted the nicks/updog branch March 17, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants