vendor: latest tilt-apiserver and default to TLS connections#4417
Merged
Conversation
Contributor
Author
|
this makes the engine tests a bit slower, but i don't totally understand why yet. i know a lot of the kubebuilder docs recommends a testing convention where you use ginkgo to create a new apiserver at the start of the package and keep it up in between tests, though i'm not sure if there's an easy way to do this without a major test refactor |
Contributor
Author
|
ugh, i think i see the problem. generating certs is very expensive and adds a lot of overhead per test. i think i need to refactor this api to generate the certs once |
Contributor
Author
|
OK, let's try this again! now with test certs in testing |
milas
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @milas,
Please review the following commits I made in branch nicks/vendor:
eee91ba (2021-04-09 15:32:23 -0400)
vendor: latest tilt-apiserver and default to TLS connections
0cdf20b (2021-04-09 15:20:01 -0400)
test: optimize engine tests a bit
Code review reminders, by giving a LGTM you attest that: