cli: add tilt alpha create cmd#4440
Merged
Merged
Conversation
|
This pull request has been linked to Clubhouse Story #11866: add tilt alpha create. |
nicks
force-pushed
the
nicks/ch11866
branch
2 times, most recently
from
April 15, 2021 20:07
aa97114 to
b26a70f
Compare
milas
approved these changes
Apr 16, 2021
|
|
||
| // A human-friendly CLI for creating cmds. | ||
| // | ||
| // The name is unfortunate. |
| "Working directory of the command. If not specified, uses the current working directory.") | ||
| cmd.Flags().StringArrayVarP(&c.env, "env", "e", nil, | ||
| "Set environment variables in the form NAME=VALUE.") | ||
| cmd.Flags().StringSliceVar(&c.filewatches, "file-watch", nil, |
Contributor
There was a problem hiding this comment.
This is a total bikeshed and not important, but since the command + API convention is just filewatch (no hyphen), it might make sense to carry that here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @milas,
Please review the following commits I made in branch nicks/ch11866:
7a19733 (2021-04-15 16:03:34 -0400)
cli: add tilt alpha create cmd
2380e96 (2021-04-15 14:49:53 -0400)
cli: add tilt alpha create filewatch
Code review reminders, by giving a LGTM you attest that: