k8swatch: convert PodWatcher to reconciler#4537
Conversation
Currently, the `PodWatcher` tests cover both: * Manifest -> KubernetesDiscovery spec creation * KubernetesDiscovery spec -> Pod discovery + status update The latter will be covered by the reconciler tests - it's not desirable to have the reconciler tests needing to create manifests and transit via the `ManifestSubscriber`, so these test specifically test the former behavior so that the reconciler tests can focus on the latter.
`PodWatcher` is now `kubernetesdiscovery.Reconciler`. Almost all the logic is the same, though some stuff moved around. Most notable change is that the check to decide whether to skip a status update now happens against the API object instead of the store object.
|
There's a few more test cases from FYI There are already (many) "integration" tests in |
|
This also fixes #4557. When there is no controller registered for a type, the We need to dive into the client caching behavior more, but this at least ensures things don't behave erratically. |
PodWatcheris nowkubernetesdiscovery.Reconciler. Almost allthe logic is the same, though some stuff moved around. Most notable
change is that the check to decide whether to skip a status update
now happens against the API object instead of the store object.