Skip to content

cli: fix a bug in 'create filewatch'#4551

Merged
nicks merged 1 commit into
masterfrom
nicks/filewatch2
May 14, 2021
Merged

cli: fix a bug in 'create filewatch'#4551
nicks merged 1 commit into
masterfrom
nicks/filewatch2

Conversation

@nicks

@nicks nicks commented May 12, 2021

Copy link
Copy Markdown
Contributor

Hello @milas,

Please review the following commits I made in branch nicks/filewatch2:

57b0640 (2021-05-12 19:55:09 -0400)
cli: fix a bug in 'create filewatch'

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
nicks requested a review from milas May 12, 2021 23:55
@nicks

nicks commented May 12, 2021

Copy link
Copy Markdown
Contributor Author

this is a minor thing, but noticed it while writing a demo

@nicks

nicks commented May 14, 2021

Copy link
Copy Markdown
Contributor Author

going to merge this cause it will help with some demos

@nicks
nicks merged commit 51e5e58 into master May 14, 2021
@nicks
nicks deleted the nicks/filewatch2 branch May 14, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant