Skip to content

k8swatch: simplify manifest subscriber logic#4572

Merged
milas merged 1 commit into
masterfrom
milas/kd-manifest-sub-cleanup
May 20, 2021
Merged

k8swatch: simplify manifest subscriber logic#4572
milas merged 1 commit into
masterfrom
milas/kd-manifest-sub-cleanup

Conversation

@milas

@milas milas commented May 20, 2021

Copy link
Copy Markdown
Contributor

While debugging, I cleaned this up a bit to make it easier to follow:

  • Fatally error if the create fails - this should never happen, but it was being silently ignored before and would have meant that no K8s resources would be discovered for a resource silently if hit, so erroring out is the best course of action for now
  • Removed redundant delete case (this made sense at one point but was an impossible to hit branch at this point)
  • Used a value instead of a pointer when processing specs (was never actually nil + makes the diff logic easier to follow)

@milas
milas requested a review from nicks May 20, 2021 13:40
@milas
milas merged commit 2ce754c into master May 20, 2021
@milas
milas deleted the milas/kd-manifest-sub-cleanup branch May 20, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants