(web) Add term input field to filters bar to filter resource logs by string#4608
Conversation
0eef42e to
e7c643a
Compare
landism
left a comment
There was a problem hiding this comment.
The epic and docs say:
- you can filter by logs span EXCLUDING [term]
- the search term is a raw string unless surrounded by
//, in which case it's a regexp
Are these still planned?
They are! I broke the epic into smaller stories, so this first one is #12046 and just covers the string search. I was planning to do the other tickets (including regexp) in the epic as fast follows. (But also lmk if there's a more preferable way for me to merge in this work.) |
e7c643a to
2c9a431
Compare
070205a to
027dea5
Compare
027dea5 to
e21d9d7
Compare
hyu
left a comment
There was a problem hiding this comment.
Nice! It took me a little while to read through this code, and I think the PR would have been a little easier to understand if it was somehow split into more PRs. (e.g., separate PR for RegEx functionality / debouncing). I appreciate your comments, like those on debouncing, since that did help me understand the code better.
I added a note re: a fix for the width change on the input that Matt also noticed.
2a83c83 to
a62da6c
Compare
a62da6c to
7584da5
Compare
…er, plus a lightweight screen-reader-only component
… handle errors and escape special characters
7584da5 to
5b666cf
Compare
Styles and tests are still a wip, but otherwise code is ready for review.
Term input field:

Filtering logs by term and level filters:

Closes ticket #12046