apis: flesh out KubernetesApplySpec#4627
Merged
Merged
Conversation
Contributor
Author
|
similarly, this is mostly fields and comments; everything else is autogenerated |
nicks
force-pushed
the
nicks/k8s3
branch
2 times, most recently
from
June 10, 2021 15:27
dbc136a to
b963244
Compare
milas
approved these changes
Jun 10, 2021
milas
reviewed
Jun 10, 2021
| package v1alpha1 | ||
|
|
||
| // Selector for any Kubernetes-style API. | ||
| type ObjectSelector struct { |
Contributor
There was a problem hiding this comment.
Not critical now because it happens later anyway, but it might be worth making this implement Validator and ensure the regexes compile so you get an error upfront when trying to create/edit the entity. (I'm 80% sure that the codegen recursively calls validate functions if subfields implement Validator)
Contributor
Author
There was a problem hiding this comment.
hmmmm...ya, let me leave a TODO for this...I not totally sure when/how the validation gets called, and would want to be able to test it better once we're using the apiserver directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @milas, @landism,
Please review the following commits I made in branch nicks/k8s3:
6937ee6 (2021-06-09 15:53:18 -0400)
apis: flesh out KubernetesApplySpec
118d37c (2021-06-09 12:45:15 -0400)
apis: add KubernetesApply, ImageMap types
Code review reminders, by giving a LGTM you attest that: