store: add a return value to OnChange, so we can add re-queueing logic#4654
Merged
Conversation
Contributor
Author
|
I'm not 100% sure we need this, but i think it will give us more peace of mind to be sure that tilt will eventually retry if it hits an apiserver error |
Contributor
Author
|
also note that there's very little logic in this change, it's mainly updating signatures and making the linter happy |
milas
approved these changes
Jun 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @milas,
Please review the following commits I made in branch nicks/onchange2:
ee5c389 (2021-06-15 13:44:10 -0400)
store: add a return value to OnChange, so we can add re-queueing logic
Code review reminders, by giving a LGTM you attest that: