Skip to content

store: add a return value to OnChange, so we can add re-queueing logic#4654

Merged
nicks merged 1 commit into
masterfrom
nicks/onchange2
Jun 15, 2021
Merged

store: add a return value to OnChange, so we can add re-queueing logic#4654
nicks merged 1 commit into
masterfrom
nicks/onchange2

Conversation

@nicks

@nicks nicks commented Jun 15, 2021

Copy link
Copy Markdown
Contributor

Hello @milas,

Please review the following commits I made in branch nicks/onchange2:

ee5c389 (2021-06-15 13:44:10 -0400)
store: add a return value to OnChange, so we can add re-queueing logic

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
nicks requested a review from milas June 15, 2021 17:44
@nicks

nicks commented Jun 15, 2021

Copy link
Copy Markdown
Contributor Author

I'm not 100% sure we need this, but i think it will give us more peace of mind to be sure that tilt will eventually retry if it hits an apiserver error

@nicks
nicks force-pushed the nicks/onchange2 branch from ee5c389 to 90f8d3c Compare June 15, 2021 17:55
@nicks

nicks commented Jun 15, 2021

Copy link
Copy Markdown
Contributor Author

also note that there's very little logic in this change, it's mainly updating signatures and making the linter happy

@nicks
nicks merged commit 13c9bb8 into master Jun 15, 2021
@nicks
nicks deleted the nicks/onchange2 branch June 15, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants