controllers: factor out an indexer API#4656
Merged
Merged
Conversation
nicks
force-pushed
the
nicks/indexer
branch
2 times, most recently
from
June 16, 2021 00:52
e2ad793 to
b70d9e5
Compare
Now that we're doing dependencies more, I felt bad duplicating this code.
milas
approved these changes
Jun 16, 2021
milas
left a comment
milas
left a comment
Contributor
There was a problem hiding this comment.
Nice!
(I do wish that ctrlclient.Client didn't have weird, deferred initialization so that we could just read the scheme off of it instead of having to pass it around again, but not much we can do about that.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @milas,
Please review the following commits I made in branch nicks/indexer:
d675d52 (2021-06-15 20:17:55 -0400)
controllers: factor out an indexer API
Now that we're doing dependencies more, I felt bad duplicating this code.
Code review reminders, by giving a LGTM you attest that: