Skip to content

rty: fix crashes when the terminal window is too small#834

Merged
nicks merged 1 commit into
masterfrom
nicks/ch1052/crash
Dec 11, 2018
Merged

rty: fix crashes when the terminal window is too small#834
nicks merged 1 commit into
masterfrom
nicks/ch1052/crash

Conversation

@nicks

@nicks nicks commented Dec 11, 2018

Copy link
Copy Markdown
Contributor

Hello @maiamcc,

Please review the following commits I made in branch nicks/ch1052/crash:

8c4e8d1 (2018-12-11 15:20:59 -0500)
rty: fix crashes when the terminal window is too small

@nicks
nicks requested a review from maiamcc December 11, 2018 20:21
@nicks
nicks force-pushed the nicks/ch1052/crash branch from 8c4e8d1 to 7e3f677 Compare December 11, 2018 20:32
@maiamcc

maiamcc commented Dec 11, 2018

Copy link
Copy Markdown
Contributor

what does it look like when we try to render in a too-small window?

@nicks
nicks force-pushed the nicks/ch1052/crash branch from 7e3f677 to 04526a8 Compare December 11, 2018 21:01
@nicks

nicks commented Dec 11, 2018

Copy link
Copy Markdown
Contributor Author

screenshot from 2018-12-11 16-01-21

@maiamcc maiamcc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

womp. cool!

@nicks
nicks merged commit d97ab58 into master Dec 11, 2018
@nicks
nicks deleted the nicks/ch1052/crash branch December 11, 2018 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants