Skip to content

hud: show build history#849

Merged
nicks merged 1 commit into
masterfrom
nicks/ch1047/historyux
Dec 19, 2018
Merged

hud: show build history#849
nicks merged 1 commit into
masterfrom
nicks/ch1047/historyux

Conversation

@nicks

@nicks nicks commented Dec 18, 2018

Copy link
Copy Markdown
Contributor

Hello @yuindustries, @jazzdan,

Please review the following commits I made in branch nicks/ch1047/historyux:

9762b91 (2018-12-17 19:23:33 -0500)
hud: show build history

@nicks
nicks requested review from hyu and jazzdan December 18, 2018 00:23
@nicks

nicks commented Dec 18, 2018

Copy link
Copy Markdown
Contributor Author

screenshot from 2018-12-17 19-13-52
screenshot from 2018-12-17 19-11-25

@jazzdan jazzdan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicks
nicks force-pushed the nicks/ch1047/historyux branch from 9762b91 to 47ab51c Compare December 18, 2018 22:29
@nicks
nicks force-pushed the nicks/ch1047/historyux branch from 47ab51c to 18ee5cb Compare December 18, 2018 22:34
@nicks

nicks commented Dec 18, 2018

Copy link
Copy Markdown
Contributor Author

@yuindustries and i reviewed the design, and decided that the (see above) text was too distracting. i changed it so that it repeats the line above, but grayed out, which is still not great, but a little bit better.

screenshot from 2018-12-18 17-28-45

@nicks
nicks merged commit d588f1e into master Dec 19, 2018
@nicks
nicks deleted the nicks/ch1047/historyux branch December 19, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants