tiltfile2: basic test for loading a docker compose manifest#850
Conversation
| if err != nil { | ||
| return nil, err | ||
| } | ||
| absConfigPath, err := filepath.Abs(configPath) |
There was a problem hiding this comment.
maybe ospath.RealAbs, like we did elsewhere?
| f := newFixture(t) | ||
| defer f.TearDown() | ||
|
|
||
| f.setupFoo() |
There was a problem hiding this comment.
this is a buncha k8s-specific setup, i'm concerned it muddies the test. maybe just specifically set up the dc-specific bits you need?
| f.file("Tiltfile", tf) | ||
|
|
||
| f.load("foo") | ||
| f.assertManifest("foo", dcYAMLPath(YAMLPath)) |
There was a problem hiding this comment.
nice. could you add a todo for me? -- assert Dockerfile and docker-compose.yml are config files
|
hmm do we want a docker compose client that we can mock out for tests so we don't actually have to call dc? |
|
@maiamcc in my opinion not right now- we only use |
|
3 participants
@maiamcc any other assertions I should add for this basic test?
I also changed the docker compose yaml path to be absolute to match how we treat other files that we read and store in memory.