Skip to content

fix test from bad merge o_0#869

Merged
maiamcc merged 1 commit into
masterfrom
maiamcc/fix-tests
Dec 20, 2018
Merged

fix test from bad merge o_0#869
maiamcc merged 1 commit into
masterfrom
maiamcc/fix-tests

Conversation

@maiamcc

@maiamcc maiamcc commented Dec 20, 2018

Copy link
Copy Markdown
Contributor

Hello @jazzdan,

Please review the following commits I made in branch maiamcc/fix-tests:

b633953 (2018-12-20 14:57:54 -0500)
fix test from bad merge o_0

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@maiamcc
maiamcc requested a review from jazzdan December 20, 2018 19:58

@jazzdan jazzdan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maiamcc
maiamcc merged commit 5d0cd96 into master Dec 20, 2018
@maiamcc
maiamcc deleted the maiamcc/fix-tests branch December 20, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants