tiltfile2: make it more clear when k8s_yaml accepts a string#897
Merged
Conversation
Contributor
|
I'm confused...the PR description is "k8s yaml accepts string", but the PR is "k8s yaml does not accept string"? |
Contributor
Author
|
Whoops, sorry @nicks that was an old title. Re-titling. |
jazzdan
changed the title
nicks
reviewed
Jan 2, 2019
| f.setupFoo() | ||
| f.WriteFile("bar.yaml", "im not yaml") | ||
| f.file("Tiltfile", ` | ||
| k8s_yaml('bar.yaml') |
Contributor
There was a problem hiding this comment.
can you also add a test case for something like
k8s_yaml(str(read_file('foo.yaml')))
nicks
approved these changes
Jan 2, 2019
| return nil, err | ||
| } | ||
| return k8s.ParseYAMLFromString(string(bs)) | ||
| entities, err := k8s.ParseYAMLFromString(string(bs)) |
Contributor
There was a problem hiding this comment.
would be slightly more idiomatic for the err != nil check to live here instead of the handle function
added 2 commits
January 2, 2019 16:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.