Skip to content

tiltfile: dc manifest tests [ch1189]#902

Merged
maiamcc merged 2 commits into
masterfrom
maiamcc/dcmanifest-tests
Jan 2, 2019
Merged

tiltfile: dc manifest tests [ch1189]#902
maiamcc merged 2 commits into
masterfrom
maiamcc/dcmanifest-tests

Conversation

@maiamcc

@maiamcc maiamcc commented Jan 2, 2019

Copy link
Copy Markdown
Contributor

Hello @jazzdan, @nicks,

Please review the following commits I made in branch maiamcc/dcmanifest-tests:

96b4592 (2019-01-02 16:03:25 -0500)
tiltfile: dc manifest tests

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@maiamcc
maiamcc requested review from jazzdan and nicks January 2, 2019 21:03

@jazzdan jazzdan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maiamcc
maiamcc merged commit e0c3b1a into master Jan 2, 2019
@maiamcc
maiamcc deleted the maiamcc/dcmanifest-tests branch January 2, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants