Skip to content

store: batch actions together so that a flood of LogActions doesn't overwhelm the subscribers#903

Merged
nicks merged 1 commit into
masterfrom
nicks/actions
Jan 3, 2019
Merged

store: batch actions together so that a flood of LogActions doesn't overwhelm the subscribers#903
nicks merged 1 commit into
masterfrom
nicks/actions

Conversation

@nicks

@nicks nicks commented Jan 2, 2019

Copy link
Copy Markdown
Contributor

Hello @landism, @maiamcc,

Please review the following commits I made in branch nicks/actions:

333607f (2019-01-02 16:09:15 -0500)
store: batch actions together so that a flood of LogActions doesn't overwhelm the subscribers

@nicks
nicks requested review from landism and maiamcc January 2, 2019 21:15
@nicks

nicks commented Jan 2, 2019

Copy link
Copy Markdown
Contributor Author

also added a bunch of tests because this code was sadly under-tested!

@landism landism left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@nicks
nicks merged commit fc5b60d into master Jan 3, 2019
@nicks
nicks deleted the nicks/actions branch January 3, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants