Skip to content

vendor: update to new starlark#904

Merged
jazzdan merged 2 commits into
masterfrom
jazzdan/update_starlark
Jan 2, 2019
Merged

vendor: update to new starlark#904
jazzdan merged 2 commits into
masterfrom
jazzdan/update_starlark

Conversation

@jazzdan

@jazzdan jazzdan commented Jan 2, 2019

Copy link
Copy Markdown
Contributor

This will allow us to enable if statements and other control structures outside of function bodies.

@jazzdan
jazzdan requested review from landism and nicks January 2, 2019 21:15

@nicks nicks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! tho we should eventually change our code to use the name starlark

Comment thread Gopkg.toml

[[constraint]]
name = "go.starlark.net/starlark.git"
branch = "options"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahaha ok

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, /me shakes fist at dep

@jazzdan

jazzdan commented Jan 2, 2019

Copy link
Copy Markdown
Contributor Author

@nicks agreed, I'll do that here.

@jazzdan
jazzdan merged commit 04c1cdb into master Jan 2, 2019
@nicks
nicks deleted the jazzdan/update_starlark branch March 31, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants