hud: show unbuilt k8s resources#905
Merged
Merged
Conversation
nicks
approved these changes
Jan 2, 2019
| }, | ||
| }, | ||
| LastDeployTime: s.GlobalYAMLState.LastSuccessfulApplyTime, | ||
| ResourceInfo: view.YamlResourceInfo{ |
Contributor
There was a problem hiding this comment.
i wonder if this means IsYAMLManifest should be a method whether than a field now, since it's now equivalent to len(ResourceInfo) > 0
Contributor
|
this is a great start, lgtm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal here is to indicate to the user that we have successfully parsed their K8s YAML, and encourage them to fill out their Tiltfile further.
I'm not saying this is the best sentence ever...
The YAML loaded from the Tiltfile includes these K8s objects:...But it's an attempt at being a bit more "friendly" and informative about what's on the UI. We can also add a prompt to encourage people to add Dockerfile info to remove "unresourced" items from this Yaml soup. (It's not in this PR because I haven't figured out good wording yet.)
Further enhancements not part of this first effort
(unless you have a compelling argument otherwise?)
hanyu-hypothesizer (Service, Deployment))