cli: down works on gyaml#910
Merged
Merged
Conversation
Contributor
Author
|
I didn't write a test because it seemed hard to test and isn't testing a whole lot of logic. Open to ideas though! |
nicks
reviewed
Jan 3, 2019
| pf PortForwarder) K8sClient { | ||
|
|
||
| // TODO(nick): I'm not happy about the way that pkg/browser uses global writers. | ||
| writer := logger.Get(ctx).Writer(logger.DebugLvl) |
Contributor
There was a problem hiding this comment.
why did you remove this? this is pretty important
Contributor
Author
There was a problem hiding this comment.
Yeah I realized that and added it back.
| for _, e := range entities { | ||
| b.WriteString(fmt.Sprintf("Deleting via kubectl: %s/%s\n", e.Kind.Kind, e.Name())) | ||
| } | ||
| l.Infof(b.String()) |
Contributor
There was a problem hiding this comment.
This will crash if the string contains any % signs.
You should either use Infof inside the loop (rather than have a separate Printf) or use something like Infof("%s", string)
nicks
approved these changes
Jan 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Kubernetes slack:
We simply weren't also deleting the global YAML resources that we record in the Tiltfile when down is called.
While I was here I made a change to the k8s client to print out which resources we're deleting, similarly to how we do it in
Upset. Looks like this: