engine: paramaterize Tiltfile#913
Merged
Merged
Conversation
Contributor
|
AFAIR, this code is super-sensitive to absolute paths vs relative paths. you need both and to use them consistently -- absolute for certain cases (like equality checking) and relative for other cases (like error messages) That's why the old code used tiltfile2.FileName to Load(). It's a relative path. You've changed it so that one call uses a relative path and the other uses an absolute path, which is going to lead to weird issues i think what we probably need to do is store the relative path on the engine state, and add a method for the absolute path. Does that make sense? I can explain more in person; it's pretty finicky. |
Contributor
Author
|
Yup, that makes sense. Will do. |
nicks
approved these changes
Jan 3, 2019
jazzdan
force-pushed
the
jazzdan/multiple_tiltfiles
branch
from
January 3, 2019 22:48
03d82be to
2a864d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to specify a different Tiltfile to load with a command line flag.