tilt: pull k8s fields out to K8SResourceInfo#917
Merged
landism merged 3 commits intoJan 4, 2019
Conversation
maiamcc
approved these changes
Jan 3, 2019
| len(res.LastBuild().Log) > 0 { | ||
| return string(res.LastBuild().Log) + "\n" + res.PodLog | ||
| } | ||
| // TODO(matt) figure out what to do with DC logs once we have DC timestamps |
Contributor
There was a problem hiding this comment.
we've already got a type switch for DC further up in this function, put this todo up there
if it's NOT either DC or k8s, do we want to freak out?
Member
Author
There was a problem hiding this comment.
we've already got a type switch for DC further up in this function, put this todo up there
done
if it's NOT either DC or k8s, do we want to freak out?
nope, it might be yaml
| @@ -9,22 +9,55 @@ import ( | |||
|
|
|||
| type ResourceInfoView interface { | |||
Contributor
There was a problem hiding this comment.
hmm should the resourceinfo stuff be its own file?
Member
Author
There was a problem hiding this comment.
maybe, but that's easy to do later, and we're about to have a few commits moving fields between these types, so might as well leave them together for now?
added 2 commits
January 4, 2019 13:35
landism
deleted the
mlandis/ch1198/move-k8s-specific-resourceview-fields-to
branch
January 4, 2019 19:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.