k8s: handle CRDs properly#953
Merged
Merged
Conversation
nicks
force-pushed
the
nicks/ch1236/crd
branch
from
January 8, 2019 22:30
9dd876e to
23067ed
Compare
maiamcc
approved these changes
Jan 9, 2019
maiamcc
left a comment
maiamcc
left a comment
Contributor
There was a problem hiding this comment.
lgtm -- tho also i think i lack context. what problem does this fix?
|
|
||
| func TestCRDYAML(t *testing.T) { | ||
| entities, err := ParseYAMLFromString(testyaml.CRDYAML) | ||
| assert.NoError(t, err) |
Contributor
There was a problem hiding this comment.
you should if err != nil {t.Fatal(err)} here so we don't continue to execute even if this step is borked and then get weird and confusing errors further down the test.
Contributor
Author
There was a problem hiding this comment.
i added a helper for it!
Contributor
Author
|
did you see the test case? there is a good example of a YAML config that didn't work before, and works now |
nicks
force-pushed
the
nicks/ch1236/crd
branch
from
January 9, 2019 17:16
23067ed to
0291a32
Compare
nicks
force-pushed
the
nicks/ch1236/crd
branch
from
January 9, 2019 17:33
0291a32 to
1d6b200
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @landism, @maiamcc,
Please review the following commits I made in branch nicks/ch1236/crd:
9dd876e (2019-01-08 17:27:42 -0500)
k8s: handle CRDs properly