Skip to content

engine: print newline before Tilt meta-logs#978

Merged
jazzdan merged 1 commit into
masterfrom
dmiller/ch979/prettify-dc-stdout
Jan 10, 2019
Merged

engine: print newline before Tilt meta-logs#978
jazzdan merged 1 commit into
masterfrom
dmiller/ch979/prettify-dc-stdout

Conversation

@jazzdan

@jazzdan jazzdan commented Jan 10, 2019

Copy link
Copy Markdown
Contributor

Some processes that could be printing to the context.Context writer will
not nicely end their strings with a newline. Let's prepend our logs with
a newline so that they stand out and don't get lost.

Some processes that could be printing to the context.Context writer will
not nicely end their strings with a newline. Let's prepend our logs with
a newline so that they stand out and don't get lost.
@jazzdan
jazzdan requested a review from maiamcc January 10, 2019 19:48

@maiamcc maiamcc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot

@jazzdan
jazzdan merged commit 87332e6 into master Jan 10, 2019
@nicks
nicks deleted the dmiller/ch979/prettify-dc-stdout branch March 31, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants