Skip to content

Use Sets to track atom relationships - #422

Merged
tim-smart merged 1 commit into
mainfrom
agent/codex-engineer/89ddfbb8
Jul 30, 2026
Merged

Use Sets to track atom relationships#422
tim-smart merged 1 commit into
mainfrom
agent/codex-engineer/89ddfbb8

Conversation

@tim-smart

Copy link
Copy Markdown
Owner

Summary

  • replace array-backed Atom parent and child relationships with Sets
  • preserve parent-child links when a derived Atom reads the same parent more than once
  • add the v4 regression test adapted to the v3 Registry API
  • include a patch changeset for @effect-atom/atom

Why

Relationship updates previously performed linear scans and swap-pop bookkeeping. Duplicate parent entries could also cause a still-active relationship to be removed during dependency reconciliation.

Validation

  • pnpm test --run (102 tests passed)
  • pnpm lint
  • pnpm check

Closes EFF-228

@tim-smart
tim-smart merged commit 5a486fb into main Jul 30, 2026
3 checks passed
@tim-smart
tim-smart deleted the agent/codex-engineer/89ddfbb8 branch July 30, 2026 10:12
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant