fix(journald source): Fix typo in metrics name#3252
Merged
Conversation
Signed-off-by: Bruce Guenter <bruce@timber.io>
bruceg
added
type: bug
fanatid
approved these changes
Jul 29, 2020
lukesteensen
approved these changes
Jul 29, 2020
Contributor
I'm a fan, ref #3247, but I think we're going to learn more as we build out the actual interfaces using this data. So I'm a little hesitant to cement everything riught now. |
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
Signed-off-by: Bruce Guenter <bruce@timber.io> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bruce Guenter bruce@timber.io
Looks like we missed this typo @lukesteensen. Thanks to @fanatid for pointing this out.
What do others think about defining constants for these common strings to make typos harder in the future?