Skip to content

feat: implement project in python #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timerring merged 3 commits into from
Dec 7, 2024
Merged

feat: implement project in python #101

timerring merged 3 commits into from
Dec 7, 2024

Conversation

@timerring
Copy link
Owner

@timerring timerring commented Dec 5, 2024

Description

Implement the scan process in python.

Related Issues

fix #38

Changes Proposed

  • adjust the naming scheme of burned videos
  • re-implement the scan process
  • refactor the process of rendering
  • adjust gitignore
  • adjust the log structure

Who Can Review?

@timerring

Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

@timerring timerring added enhancement New feature or request feature labels Dec 5, 2024
@timerring timerring self-assigned this Dec 5, 2024
timerring
timerring commented Dec 5, 2024
View reviewed changes
Copy link
Owner Author

@timerring timerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Wait for test.

timerring
timerring commented Dec 5, 2024
View reviewed changes
Copy link
Owner Author

@timerring timerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD.

timerring
timerring commented Dec 7, 2024
View reviewed changes
Copy link
Owner Author

@timerring timerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.

@timerring timerring merged commit 8775d89 into main Dec 7, 2024
@timerring timerring deleted the dev branch December 7, 2024 07:24
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@timerring timerring

Labels

enhancement New feature or request feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] The project can be refactored with python

2 participants

@timerring