Skip to content

chore: augmented assignment review follow-ups 🧹 - #195

Merged
timfennis merged 3 commits into
refactor/compiler-temp-layoutfrom
housekeeping/augmented-assignment-followup
Aug 23, 2026
Merged

chore: augmented assignment review follow-ups 🧹#195
timfennis merged 3 commits into
refactor/compiler-temp-layoutfrom
housekeeping/augmented-assignment-followup

Conversation

@timfennis

Copy link
Copy Markdown
Owner

Follow-ups from the review of #192, stacked on #193. The review's bigger findings (fuzzer metadata wiring) were made obsolete by the temp-layout refactor in #193; these are the pieces that survived.

Changes

  • analyser: named the Binding::None arms in the augmented-assignment plan match (fixes the match_wildcard_for_single_variants clippy warning introduced by fix: fixed augmented assignment 🦾 #192) and extracted the twice-duplicated "index type is an int-range slice" check into index_type_is_slice.
  • compiler: compile_batch now takes the expression iterator directly instead of forcing every caller to .collect() into a Vec first.
  • manual: the augmented-assignment page only documented variable targets; added sections for indexed/slice/string targets, the once-each evaluation-order guarantee, and the type-checking rules (in-place operators preserve the target type, fallback operators may widen). All new examples are verified to run.

Remaining clippy warnings (chunk.rs use_self, only_used_in_recursion, doc backticks) pre-date this stack on master and are left for a separate cleanup.

🤖 Generated with Claude Code

timfennis and others added 3 commits August 23, 2026 18:06
…ms 🧹

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@timfennis
timfennis force-pushed the housekeeping/augmented-assignment-followup branch from 2c8b47f to ec6b51a Compare August 23, 2026 16:07
@timfennis
timfennis merged commit bdef5d5 into master Aug 23, 2026
2 checks passed
@timfennis
timfennis deleted the housekeeping/augmented-assignment-followup branch August 23, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant