chore: augmented assignment review follow-ups 🧹 - #195
Merged
timfennis merged 3 commits intoAug 23, 2026
Merged
Conversation
…ms 🧹 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
timfennis
force-pushed
the
housekeeping/augmented-assignment-followup
branch
from
August 23, 2026 16:07
2c8b47f to
ec6b51a
Compare
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the review of #192, stacked on #193. The review's bigger findings (fuzzer metadata wiring) were made obsolete by the temp-layout refactor in #193; these are the pieces that survived.
Changes
Binding::Nonearms in the augmented-assignment plan match (fixes thematch_wildcard_for_single_variantsclippy warning introduced by fix: fixed augmented assignment 🦾 #192) and extracted the twice-duplicated "index type is an int-range slice" check intoindex_type_is_slice.compile_batchnow takes the expression iterator directly instead of forcing every caller to.collect()into aVecfirst.Remaining clippy warnings (
chunk.rsuse_self,only_used_in_recursion, doc backticks) pre-date this stack on master and are left for a separate cleanup.🤖 Generated with Claude Code