fix: harden struct parsing, copying, and tooling after review 🛡️ - #204
Merged
Conversation
- Member/index lvalues in for-loop iteration variables and function parameters are parse errors instead of compiler/parser panics - Struct declarations are statements like let; value position no longer corrupts the VM stack - (s.f)() keeps its Grouping so it calls the stored function instead of silently lowering to method-call form f(s) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ffb6966313
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
timfennis
commented
Aug 26, 2026
…agraph ✍️ Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
A final adversarial review of #197 (after it merged) surfaced four real bugs and two smaller gaps. This PR fixes all six. Each bug was reproduced before fixing and has a regression test.
Fixes
for (p.x) in [1, 2, 3]hitunreachable!("cannot declare into a field"). For-loop iteration variables now go through the samenon_binding_targetcheck aslet. The probe also uncovered thatfn f(p.x)/fn f(l[0])panicked inFunctionParameter::from_params(the index case pre-dates structs) — parameters are now required to be plain identifiers at parse time.[struct R { x: Int }, 5]printed[,5]) pushed no value. Struct declarations are now statements, parsed exactly likelet, so value position is a parse error.(s.f)()silently called the getter method-style instead of the function stored in the field. Parenthesized member access now keeps anExpression::Groupingwrapper so the postfix-call rewrite can tell it apart froms.f(). Grouping was never constructed by the parser before, so its (dead) lvalue arms were redefined as transparent:(s.x) = 5,(s.x) += 2, and(l[0]) = 9behave exactly as before.clone()aliased structs anddeepcopy()shared nested state —Object::Structfell into both catch-all arms. Structs now copy like the other mutable containers:clonegives an independent instance (nested containers shared, like lists),deepcopyshares nothing.structkeyword was missing from the REPL highlighter and the LSP keyword completion list.StaticTypes inline; it now usesStructInfo::constructor_type()/getter_type()/setter_type()— the same source of truth the runtime functions use.🤖