fix: handle ENOTDIR in FileDataAccessor.getStats to prevent 500 on duplicate slug - #1
Draft
timgent wants to merge 2 commits into
Draft
fix: handle ENOTDIR in FileDataAccessor.getStats to prevent 500 on duplicate slug#1timgent wants to merge 2 commits into
timgent wants to merge 2 commits into
Conversation
…plicate slug When a file already exists at a given path, stat()-ing that path with a trailing slash (e.g. test.json/) causes the OS to return ENOTDIR instead of ENOENT. This error was not caught by getStats, causing it to propagate as a raw OS error and result in a 500 InternalServerError on the second POST with the same Slug header to a file-system-backed server. Treating ENOTDIR the same as ENOENT (i.e. converting it to NotFoundHttpError) means hasResource correctly returns false for the container-style path check, allowing createSafeUri to fall back to a UUID-based name for the duplicate upload. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-backend Verify that a second POST with the same Slug to a file-system-backed container returns 201 with a UUID-based location rather than crashing with a 500 InternalServerError (ENOTDIR). Also adds /.data to .gitignore and eslint.config.mjs ignores to prevent the local server data directory from being linted during development. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
timgent
marked this pull request as draft
April 18, 2026 17:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a file already exists at a given path, stat()-ing that path with a
trailing slash (e.g. test.json/) causes the OS to return ENOTDIR instead
of ENOENT. This error was not caught by getStats, causing it to propagate
as a raw OS error and result in a 500 InternalServerError on the second
POST with the same Slug header to a file-system-backed server.
Treating ENOTDIR the same as ENOENT (i.e. converting it to
NotFoundHttpError) means hasResource correctly returns false for the
container-style path check, allowing createSafeUri to fall back to a
UUID-based name for the duplicate upload.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com