Add public local Codex speed testing - #3
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6fd487f8f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| warmup: true, | ||
| models: [model.id], | ||
| efforts: [effort], |
There was a problem hiding this comment.
Warm up using the selected reasoning effort
When a user selects a non-default effort (for example --effort high on a model whose default is medium), this schedule delegates the warm-up to buildSchedule, which chooses the model default effort for warm-ups rather than the filtered effort. The runner therefore displays and obtains confirmation for one selected effort but starts an additional real turn at a different effort; this can both misrepresent the chosen test configuration and consume a different allowance than the user expects. Construct the guided warm-up with effort explicitly, or disclose that distinct warm-up effort before confirmation.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2244dfa75f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| isAvailable: async (path) => | ||
| access(path).then( | ||
| () => true, | ||
| () => false, | ||
| ), |
There was a problem hiding this comment.
Require an executable Codex candidate
access(path) defaults to an existence check, so a non-executable file (or directory) named codex in an earlier PATH entry is selected and prevents discovery from reaching a later working Codex installation. In that setup every guided command fails when spawning the chosen candidate, rather than using the usable binary; probe executable permission on POSIX (and an appropriate runnable-file check on Windows) before returning it.
Useful? React with 👍 / 👎.
Summary
codexspeedcommand that discovers the installed Codex model catalog, shows the exact turn count and usage warning, requires explicit confirmation, prints local metrics, and never uploads automatically.codex.cmdcompatibility and native CI smoke tests./local, where any visitor can download the runner and open a result JSON entirely through the browser File API without API traffic.Validation
corepack pnpm check