Skip to content

Push artifacts as single-layer image directly to final ref#37

Merged
mergify[bot] merged 1 commit intotinkerbell:mainfrom
jacobweinstock:refactor-crane
Mar 5, 2026
Merged

Push artifacts as single-layer image directly to final ref#37
mergify[bot] merged 1 commit intotinkerbell:mainfrom
jacobweinstock:refactor-crane

Conversation

@jacobweinstock
Copy link
Copy Markdown
Member

Description

GHCR requires packages:delete permission to remove tags, so the WIP tag cleanup was silently failing, leaving orphaned *-wip tags in the registry. Eliminate the WIP pattern entirely by bundling all artifact files into one tar layer and pushing straight to the final ref in a single crane append.

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

GHCR requires packages:delete permission to remove tags, so the WIP tag
cleanup was silently failing, leaving orphaned *-wip tags in the registry.
Eliminate the WIP pattern entirely by bundling all artifact files into one
tar layer and pushing straight to the final ref in a single crane append.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread captain/oci.py
@jacobweinstock jacobweinstock added the ready-to-merge Signal Mergify to merge the PR label Mar 5, 2026
@mergify mergify bot added the queued label Mar 5, 2026
mergify bot added a commit that referenced this pull request Mar 5, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 5, 2026

Merge Queue Status

Rule: default


This pull request spent 5 minutes 6 seconds in the queue, including 4 minutes 55 seconds running CI.

Required conditions to merge
  • #changes-requested-reviews-by=0
  • base=main
  • check-success=DCO
  • check-success=build-initramfs (amd64)
  • check-success=build-initramfs (arm64)
  • check-success=build-iso (amd64)
  • check-success=build-iso (arm64)
  • check-success=build-kernel (amd64)
  • check-success=build-kernel (arm64)
  • check-success=download-tools (amd64)
  • check-success=download-tools (arm64)
  • label!=do-not-merge
  • label=ready-to-merge
  • queue-position>=0
  • any of:
  • any of [🛡 GitHub repository ruleset rule main]:
    • check-success = build-initramfs (amd64)
    • check-neutral = build-initramfs (amd64)
    • check-skipped = build-initramfs (amd64)
  • any of [🛡 GitHub repository ruleset rule main]:
    • check-success = build-initramfs (arm64)
    • check-neutral = build-initramfs (arm64)
    • check-skipped = build-initramfs (arm64)
  • any of [🛡 GitHub repository ruleset rule main]:
    • check-success = build-kernel (amd64)
    • check-neutral = build-kernel (amd64)
    • check-skipped = build-kernel (amd64)
  • any of [🛡 GitHub repository ruleset rule main]:
    • check-success = build-kernel (arm64)
    • check-neutral = build-kernel (arm64)
    • check-skipped = build-kernel (arm64)
  • any of [🛡 GitHub repository ruleset rule main]:
    • check-success = download-tools (amd64)
    • check-neutral = download-tools (amd64)
    • check-skipped = download-tools (amd64)
  • any of [🛡 GitHub repository ruleset rule main]:
    • check-success = download-tools (arm64)
    • check-neutral = download-tools (arm64)
    • check-skipped = download-tools (arm64)
  • any of [🛡 GitHub repository ruleset rule main]:
    • check-success = build-iso (amd64)
    • check-neutral = build-iso (amd64)
    • check-skipped = build-iso (amd64)
  • any of [🛡 GitHub repository ruleset rule main]:
    • check-success = build-iso (arm64)
    • check-neutral = build-iso (arm64)
    • check-skipped = build-iso (arm64)

@mergify mergify bot merged commit e40f755 into tinkerbell:main Mar 5, 2026
64 of 68 checks passed
@mergify mergify bot removed the queued label Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Signal Mergify to merge the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants