compute kernel cache key before build:#54
Merged
mergify[bot] merged 1 commit intotinkerbell:mainfrom Mar 9, 2026
Merged
Conversation
The kernel build writes .config.resolved into kernel.configs/,
which changes the hashFiles('kernel.configs/*', ...) result between
cache restore and save, producing mismatched keys and failed saves.
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes GitHub Actions kernel cache save failures caused by the kernel build generating kernel.configs/.config.resolved, which changes hashFiles('kernel.configs/*', ...) between the cache restore and cache save steps.
Changes:
- Compute the kernel cache key once (before the kernel build) and reuse it for both cache restore and cache save.
- Replace inline
hashFiles(...)usage in the kernel cache restore/save steps with the precomputed step output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
97 tasks
Contributor
Merge Queue Status
This pull request spent 10 minutes 42 seconds in the queue, including 10 minutes 28 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The kernel build writes .config.resolved into kernel.configs/, which changes the hashFiles('kernel.configs/*', ...) result between cache restore and save, producing mismatched keys and failed saves.
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: