Tinty custom generated schemes not recognized

[hadallen]

Hi, I found that custom generated schemes are not recognized by the neovim plugin, only built-in colorschemes are found.

I have set up tinted-nvim in my tinty config.toml and have as well added the tinted-theming/tinted-nvim neovim plugin, and created a custom generated scheme (using tinty generate-schema --save --system=base16 /path/to/img.png)

A workaround is to use the .vim file method found in the tinty USAGE.md. I've set the theme script path to the generated file directly:

local theme_script_path = vim.fn.expand("~/.local/share/tinted-theming/tinty/repos/neovim/colors/base24-tinty-generated.vim")

local function file_exists(file_path)
  return vim.fn.filereadable(file_path) == 1 and true or false
end

local function handle_focus_gained()
  if file_exists(theme_script_path) then
      vim.cmd("source " .. theme_script_path)
  end
end

if file_exists(theme_script_path) then
  vim.o.termguicolors = true
  vim.g.tinted_colorspace = 256

  vim.cmd("source " .. theme_script_path)

  vim.api.nvim_create_autocmd("FocusGained", {
    callback = handle_focus_gained,
  })
end

but, using the :colorscheme command in nvim, it is not found:

[JamyGolden]

I think the best way to solve this is to install tinted-nvim slightly differently, since we need Tinty to build the themes of a template when applying a custom scheme, Tinty needs to have access to that repo.

1. Add tinted-nvim to the list of templates to build in your tinty config.toml
   Append the following to your ~/.config/tinted-theming/tinty/config.toml (set the path correctly to your locally cloned version of tinted-nvim)

   [[items]]
   path = "~/projects/tinted-theming/tinted-nvim"
   name = "tinted-nvim"
   themes-dir = "colors"
   supported-systems = ["base16", "base24"]

2. Make sure you're using a local version of tinted-nvim within your plugin manager
   This is what I have in my lazy.nvim setup under .../plugins/tinted-nvim.lua

   return {
     "~/tinted-theming/tinted-nvim",
     dev = true,
     config = function()
       require("tinted-colorscheme").setup(nil)
     end
   }

Let me know if this works for you and thanks for creating the issue.

[hadallen]

I think the best way to solve this is to install tinted-nvim slightly differently, since we need Tinty to build the themes of a template when applying a custom scheme, Tinty needs to have access to that repo.

1. Add `tinted-nvim` to the list of templates to build in your tinty `config.toml`
   Append the following to your `~/.config/tinted-theming/tinty/config.toml` (set the path correctly to your locally cloned version of tinted-nvim)
   [[items]]
   path = "~/projects/tinted-theming/tinted-nvim"
   name = "tinted-nvim"
   themes-dir = "colors"
   supported-systems = ["base16", "base24"]

2. Make sure you're using a local version of `tinted-nvim` within your plugin manager
   This is what I have in my lazy.nvim setup under `.../plugins/tinted-nvim.lua`
   return {
     "~/tinted-theming/tinted-nvim",
     dev = true,
     config = function()
       require("tinted-colorscheme").setup(nil)
     end
   }

Let me know if this works for you and thanks for creating the issue.

wonderful! this worked nicely!

I was able to follow these steps and get it working :)

• cloned the tinted-nvim repo locally
• set the path in my tinty/config.toml to point to it instead of the github repo
• added that lua snippet to my neovim plugins folder, replacing my previous lazy call which loaded "tinted-theming/tinted-nvim".

Now my generated colorschemes are found and applied :) Thank you for the easier workaround.

[JamyGolden]

No problem! Glad it worked. I’ll add some info to the tinted-nvim readme before closing the issue.

[rwendell]

A solution that I came up with using tinty hooks:

First make sure you have the directory:
mkdir -p ~/.config/nvim/colors

tinty config:

[[items]]
path = "https://github.com/tinted-theming/tinted-nvim"
name = "tinted-nvim"
themes-dir = "colors"
supported-systems = ["base16", "base24"]
hook = "command cp -f %f ~/.config/nvim/colors"

plugin init:

return {
	{
		"tinted-theming/tinted-nvim",
		config = function()
			vim.cmd([[colorscheme tinted-nvim-colors-file]])
		end
	}
}

[josswright]

A solution that I came up with using tinty hooks:

First make sure you have the directory: mkdir -p ~/.config/nvim/colors

tinty config:

[[items]]
path = "https://github.com/tinted-theming/tinted-nvim"
name = "tinted-nvim"
themes-dir = "colors"
supported-systems = ["base16", "base24"]
hook = "command cp -f %f ~/.config/nvim/colors"

plugin init:

return {
{
"tinted-theming/tinted-nvim",
config = function()
vim.cmd([[colorscheme tinted-nvim-colors-file]])
end
}
}

Just ran into this issue myself, and trying to work out which of the two suggested approaches is best. This hook approach seems much neater than having a separate manual git checkout of tinted-nvim elsewhere.

How does this approach interact with the other options, like live-reload, etc., given that it's not explicitly calling the setup() function?

Is there a better way to handle this in the 'core' of the plugin?

[josswright]

Just an update here, as I think I've found a version that works for me, and particularly using lazy.nvim (although not full LazyVim).

$HOME/.nvim/lua/plugins/tinted-nvim.lua:

return {
  "tinted-theming/tinted-nvim",
  priority = 1000,
  opts = {
    supports = {
      tinty = true,
      tinted_shell = true,
      live_reload = true,
      transparent = true
    },
    highlights = {
      telescope = true,
      indentblankline = true,
      notify = true,
      ts_rainbow = true,
      cmp = true,
      illuminate = true,
      lsp_semantic = true
    }
  },
  config = function( _, opts )
     require('tinted-colorscheme').setup(nil,opts)
  end
}

$HOME/.config/tinted-theming/tinty/config.toml:

...
[[items]]
name = "tinted-nvim"
path = "https://github.com/tinted-theming/tinted-nvim" 
themes-dir = "colors"
supported-systems = ["base16", "base24"]
hook = 'command cp -f $HOME/.local/share/tinted-theming/tinty/repos/tinted-nvim/lua/colors/%n.lua $HOME/.local/share/nvim/lazy/tinted-nvim/lua/colors/%n.lua' # This is hacky, but works for the moment while developing a custom theme.
...

(Note here that I can't use %f for the above, because that points to the .vim version, and I couldn't see a way to access the .lua version more neatly.)

This all seems to work for me now! (Although, as mentioned in tinted-theming/tinty#130, I've patched tinty to ignore untracked files in its generated repositories so that I can iterate on the theme as I develop it.)

[rwendell]

Great implementation! Mine didn't support live-reload because it only checked through the publicly available repos. Stealing this

[josswright]

Great implementation! Mine didn't support live-reload because it only checked through the publicly available repos. Stealing this

Steal away! :)

One thing I have noticed is that live reload doesn't seem to work for iterating on a scheme--it won't apply changes to a theme if you edit it after being applied and then rerunning tinty apply. (Even if you first apply another scheme and go back to the altered one.) Not really a huge problem, as it's a bit of a niche case, but I thought I'd mention it.

[josswright]

A second strange thing I've noticed.

When running tinty apply <custom-scheme> again after loading neovim, I'm getting an odd behaviour with the colours in my lualine. Everything else seemsm more or less unaffected, but the COMMAND highlight colour in my lualine changes from the scheme's base08 colour to what looks like a default red colour:

Initial load of neovim with theme applied:

Switch (without restarting neovim) after re-running tinty apply <custom scheme>):

I haven't been able to spot this happening with any other highlights, and the list shown by :highlight doesn't seem to be affected. It also doesn't seem to happen with other, built-in schemes.

I'm really beginning to feel that the answer here is just to finalize the scheme locally and push it to the theme repository... :)

[rwendell]

Yeah, that happened to me too. I think it's how nvim loads the colorscheme registry.  Have you considered rasing a pr to integrate your colorscheme into the tinty org? That way you don't need to worry about custom schemes 😏

[josswright]

Yeah, that happened to me too. I think it's how nvim loads the colorscheme registry. Have you considered rasing a pr to integrate your colorscheme into the tinty org? That way you don't need to worry about custom schemes 😏

That's the plan!