Validate the incoming cursor where the criteria is parsed. - #10
Merged
gustavofreze merged 1 commit intoSep 3, 2026
Merged
Conversation
Criteria::fromQuery documented itself as the point where the query string is validated, and raised eight of the nine failures a malformed request can produce. The cursor was the exception: Token defers the decode, so CursorIsInvalid surfaced from SeekClause while the seek was being built, long past the try every consumer wraps fromQuery in. Every consumer therefore answered 500 to a tampered cursor instead of 422. Decoding at the boundary completes the contract and fixes them with no change on their side.
gustavofreze
deleted the
fix/validate-cursor-token-at-the-criteria-boundary
branch
September 3, 2026 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Criteria::fromQuery documented itself as the point where the query string is validated, and raised eight of the nine failures a malformed request can produce. The cursor was the exception: Token defers the decode, so CursorIsInvalid surfaced from SeekClause while the seek was being built, long past the try every consumer wraps fromQuery in. Every consumer therefore answered 500 to a tampered cursor instead of 422. Decoding at the boundary completes the contract and fixes them with no change on their side.
Summary
What this pull request does.
Related issue
Closes #...
Checklist
make reviewpasses.make testspasses.