New Crowdin updates#116
Conversation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 42
🧹 Nitpick comments (7)
frontend/src/lib/i18n/locales/cs-CZ.json (1)
49-50: Add password recovery title
The addition of"forgotPasswordTitle"and the trailing comma after"cancelTitle"preserve valid JSON syntax. However, the new string is still in English; please supply the correct Czech translation. You may also consider moving this key closer to other login-related entries for logical grouping.frontend/src/lib/i18n/locales/no-NO.json (1)
49-50: Forgot-password title insertion.
You’ve added"forgotPasswordTitle"and correctly introduced a comma on the preceding"cancelTitle". Ensure this new prompt is translated into Norwegian, and consider whether its placement (at the very end) maintains consistency with other login-flow keys.frontend/src/lib/i18n/locales/pt-BR.json (1)
2-2: Verify and standardize translation forloginTitle
The updated value"Bem-vindo de volta, acesse com"reads awkwardly in Portuguese and may not convey the intended meaning. Consider aligning with the original intent, for example:- "loginTitle": "Bem-vindo de volta, acesse com", + "loginTitle": "Bem-vindo de volta! Faça login com",This preserves clarity and consistency across locales.
frontend/src/lib/i18n/locales/el-GR.json (1)
44-44: Verify translation and grammar forunauthorizedLoginSubtitle.
The value is still in English and uses “login” as a noun rather than the verb form “log in.” In the Greek locale, please provide the proper Greek translation (e.g., “Ο χρήστης με όνομα χρήστη{{username}}δεν εξουσιοδοτείται να συνδεθεί.”) and confirm that the updated key name (unauthorizedLoginSubtitle) matches what the UI components expect.frontend/src/lib/i18n/locales/sr-SP.json (1)
49-50: Confirm translation and section grouping.You’ve added
"cancelTitle"and"forgotPasswordTitle"—remember to propagate these keys to all locale JSONs and supply the correct Serbian translations. For improved maintainability, consider grouping related button titles (e.g., cancel, retry, submit) together consistently within this file.frontend/src/lib/i18n/locales/en-US.json (1)
44-44: Correct grammar for authorization message
Use the verb “log in” rather than the noun “login” to improve readability.
Apply this diff:- "unauthorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.", + "unauthorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to log in.",frontend/src/lib/i18n/locales/da-DK.json (1)
49-50: Translate and validate the new forgot password key
The new"forgotPasswordTitle"entry uses English text in the Danish locale. It should be translated into Danish. For example:- "forgotPasswordTitle": "Forgot your password?" + "forgotPasswordTitle": "Glemt din adgangskode?"The added comma after
"cancelTitle"is correct to maintain valid JSON before the new entry.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (30)
frontend/src/lib/i18n/locales/af-ZA.json(1 hunks)frontend/src/lib/i18n/locales/ar-SA.json(1 hunks)frontend/src/lib/i18n/locales/ca-ES.json(1 hunks)frontend/src/lib/i18n/locales/cs-CZ.json(1 hunks)frontend/src/lib/i18n/locales/da-DK.json(1 hunks)frontend/src/lib/i18n/locales/de-DE.json(1 hunks)frontend/src/lib/i18n/locales/el-GR.json(1 hunks)frontend/src/lib/i18n/locales/en-US.json(1 hunks)frontend/src/lib/i18n/locales/es-ES.json(1 hunks)frontend/src/lib/i18n/locales/fi-FI.json(1 hunks)frontend/src/lib/i18n/locales/fr-FR.json(1 hunks)frontend/src/lib/i18n/locales/he-IL.json(1 hunks)frontend/src/lib/i18n/locales/hu-HU.json(1 hunks)frontend/src/lib/i18n/locales/it-IT.json(1 hunks)frontend/src/lib/i18n/locales/ja-JP.json(1 hunks)frontend/src/lib/i18n/locales/ko-KR.json(1 hunks)frontend/src/lib/i18n/locales/nl-NL.json(1 hunks)frontend/src/lib/i18n/locales/no-NO.json(1 hunks)frontend/src/lib/i18n/locales/pl-PL.json(1 hunks)frontend/src/lib/i18n/locales/pt-BR.json(2 hunks)frontend/src/lib/i18n/locales/pt-PT.json(1 hunks)frontend/src/lib/i18n/locales/ro-RO.json(1 hunks)frontend/src/lib/i18n/locales/ru-RU.json(1 hunks)frontend/src/lib/i18n/locales/sr-SP.json(1 hunks)frontend/src/lib/i18n/locales/sv-SE.json(1 hunks)frontend/src/lib/i18n/locales/tr-TR.json(1 hunks)frontend/src/lib/i18n/locales/uk-UA.json(1 hunks)frontend/src/lib/i18n/locales/vi-VN.json(1 hunks)frontend/src/lib/i18n/locales/zh-CN.json(1 hunks)frontend/src/lib/i18n/locales/zh-TW.json(1 hunks)
🔇 Additional comments (43)
frontend/src/lib/i18n/locales/hu-HU.json (3)
44-44: Typo corrected in localization key
The key"unaothorizedLoginSubtitle"has been fixed to"unauthorizedLoginSubtitle"to align with other locale files and ensure consistency.
45-45: New key for group authorization subtitle
Added"unauthorizedGroupsSubtitle"to inform users when they are not in the required groups for a resource.
49-50: Added forgot password title and supporting comma
Inserted a trailing comma on"cancelTitle"and the new key"forgotPasswordTitle"to support the password recovery prompt.frontend/src/lib/i18n/locales/es-ES.json (1)
44-44: Verify key rename consistency
The typo fix renames"unaothorizedLoginSubtitle"→"unauthorizedLoginSubtitle". Ensure that:
- All code references and fallback lookups have been updated to use the new key.
- No instances of the old key remain in this or other locale files.
frontend/src/lib/i18n/locales/af-ZA.json (4)
44-44: Typo corrected:unauthorizedLoginSubtitle
The key has been renamed correctly (previously “unaothorizedLoginSubtitle”).
45-45: Added missing localization key:unauthorizedGroupsSubtitle
This new entry covers scenarios where a user isn’t in the required groups. Ensure it’s translated in other locales.
49-49: Added trailing comma for JSON validity
Including a comma after"cancelTitle"is required to maintain valid JSON when appending new keys.
50-50: Added new key:forgotPasswordTitle
Supports the password-recovery flow. Placeholder is in English; consider providing an Afrikaans translation.frontend/src/lib/i18n/locales/cs-CZ.json (1)
44-45: Correct typo fix and new group subtitle
The typo in"unaothorizedLoginSubtitle"has been fixed to"unauthorizedLoginSubtitle"and the new"unauthorizedGroupsSubtitle"key matches the updates in other locales. Please verify that both messages are translated into Czech, as they currently remain in English.frontend/src/lib/i18n/locales/ar-SA.json (1)
49-49: Trailing comma is correct JSON syntax.
The comma after"cancelTitle"is necessary because another key follows. This change is valid.frontend/src/lib/i18n/locales/de-DE.json (2)
47-49: Translations for redirect and cancel keys look correct
The German texts for"untrustedRedirectTitle","untrustedRedirectSubtitle", and"cancelTitle"are accurate and maintain consistency with the rest of the locale.
50-50: NewforgotPasswordTitletranslation is accurate
The German string"Passwort vergessen?"correctly conveys the intended meaning and follows locale style.frontend/src/lib/i18n/locales/no-NO.json (2)
44-44: Typo fix in the key is correct.
The JSON key has been corrected from"unaothorizedLoginSubtitle"to"unauthorizedLoginSubtitle", matching the change in other locales.
45-45: New group-authorization subtitle added.
The"unauthorizedGroupsSubtitle"key aligns with the feature for group-based access control. Please verify that this entry has been localized into Norwegian (or confirm that English fallback is intended until the translation is ready).frontend/src/lib/i18n/locales/pt-BR.json (1)
49-50: Approve addition offorgotPasswordTitleand comma adjustment
The comma after"cancelTitle"is correctly added and the new key"forgotPasswordTitle": "Esqueceu sua senha?"is properly localized and valid JSON.frontend/src/lib/i18n/locales/tr-TR.json (4)
44-44: Corrected typo in localization key
The keyunaothorizedLoginSubtitlehas been correctly renamed tounauthorizedLoginSubtitle, aligning with other locale files. Please verify that all code references and other translation files have been updated to use the new key to prevent any missing-string runtime errors.
45-45: New localization key requires Turkish translation
The newly added keyunauthorizedGroupsSubtitlecurrently contains an English message. For consistency in the Turkish locale, please provide a proper Turkish translation for this entry or confirm it’s intended as an English placeholder.
49-49: JSON property separator
Adding the comma after"cancelTitle"is correct and necessary to separate this property from the next one.
50-50: New localization key requires Turkish translation
The keyforgotPasswordTitlehas been added with an English value ("Forgot your password?"). Please translate this string into Turkish or confirm that using English here is acceptable for thetr-TRlocale.frontend/src/lib/i18n/locales/el-GR.json (2)
45-45: Provide Greek translation forunauthorizedGroupsSubtitle.
This new message is currently in English. Please supply the equivalent Greek localization and ensure any UI references to this key are updated accordingly.
50-50: TranslateforgotPasswordTitleinto Greek.
The English placeholder “Forgot your password?” should be replaced with the appropriate Greek text (e.g., “Ξεχάσατε τον κωδικό πρόσβασης;”).frontend/src/lib/i18n/locales/it-IT.json (4)
44-44: Fixed typo in i18n key.
The key"unauthorizedLoginSubtitle"corrects the previous misspelling (unaothorizedLoginSubtitle). Ensure the old key is removed across all locale files and that any code referencing the misspelled key has been updated to avoid missing translations at runtime.
45-45: Added new i18n key for group-based authorization.
The new"unauthorizedGroupsSubtitle"key provides a message when users lack the necessary groups. Please verify that the front-end authorization error component is updated to reference this key and extend any TypeScript i18n type definitions (e.g., yourI18nKeysunion) to include it.
49-49: Inserted comma for valid JSON syntax.
Adding the comma after the"cancelTitle"entry ensures the JSON remains valid when new keys are appended.
50-50: Introduce translation key for password recovery prompt.
The"forgotPasswordTitle"key supports the “Forgot your password?” UI flow. Confirm that the password recovery screen/component references this key and that equivalent entries are present in all other locale files to maintain consistency.frontend/src/lib/i18n/locales/fr-FR.json (2)
44-45: Typo fix correct but missing French translationThe key
unauthorizedLoginSubtitlehas been correctly renamed (fixing the typo) and the newunauthorizedGroupsSubtitleentry is in place. However, both message values remain in English. Since this is the French locale, please provide proper French translations for these keys.
49-50: French translations needed for new keysThe
cancelTitlevalue (“Cancel”) and the newforgotPasswordTitle(“Forgot your password?”) are currently in English. For the French locale, these should be translated (e.g., “Annuler” and “Mot de passe oublié ?”). Please update with the correct French strings.frontend/src/lib/i18n/locales/ru-RU.json (2)
44-44: Typo fix applied correctly
Great catch fixing the key from"unaothorizedLoginSubtitle"to"unauthorizedLoginSubtitle". Make sure this key matches the lookup in the code.
49-49: Trailing comma added for JSON validity
The comma after"cancelTitle"is required to keep the JSON valid when adding more entries—this looks good.frontend/src/lib/i18n/locales/sr-SP.json (1)
44-45: Verify removal of the old typo key and code references.Great catch correcting
"unauthorizedLoginSubtitle". Please ensure that the old mistyped key ("unaothorizedLoginSubtitle") has been removed from all locale files and that any code references (e.g., UI components or tests) have been updated to use the corrected key. Also confirm that the newly added"unauthorizedGroupsSubtitle"is present in every locale and will be translated appropriately.frontend/src/lib/i18n/locales/pl-PL.json (2)
49-49: Correct trailing comma additionAdding a comma after
"cancelTitle"is necessary now that"forgotPasswordTitle"follows. This maintains valid JSON syntax.
50-50: Proper Polish translation addedThe
"forgotPasswordTitle"key has been correctly added and is localized in Polish.frontend/src/lib/i18n/locales/he-IL.json (1)
49-50: Added cancel and forgot-password localization keys
The new"cancelTitle"entry now ends with a trailing comma, and the"forgotPasswordTitle"key is appended correctly. JSON syntax remains valid and the keys follow existing naming conventions.frontend/src/lib/i18n/locales/pt-PT.json (2)
49-49: Added trailing comma aftercancelTitleto maintain JSON validityA comma was added after
"cancelTitle": "Cancel"so the JSON remains syntactically correct with subsequent entries.
45-45:Details
❓ Verification inconclusive
Added new i18n key for unauthorized groups
Introduced
"unauthorizedGroupsSubtitle"to cover the scenario where a user isn’t in the required groups. Confirm that this key is consumed by the UI logic for group-based authorization messages.Run the following to confirm the code references this new key:
🏁 Script executed:
#!/bin/bash # Check where the new i18n key is used rg -n "unauthorizedGroupsSubtitle" -n .Length of output: 5984
Missing UI reference for the new i18n key
I see the keyunauthorizedGroupsSubtitlewas added to all locale files, but there are no usages in the UI code. Please confirm that the component rendering group-based authorization errors has been updated to consume this key.• Search for any references in your source tree:
rg -n unauthorizedGroupsSubtitle -n frontend/src• If no hits are found, update the relevant component (e.g. the group-authorization or error-message component) to:
import { t } from 'i18n'; … <Subtitle> {t('unauthorizedGroupsSubtitle', { username, resource })} </Subtitle>Ensure you wrap the placeholders with
<Code>as in other messages.frontend/src/lib/i18n/locales/sv-SE.json (1)
49-49: PR summary inconsistency
The addition of"cancelTitle": "Cancel"isn’t mentioned in the PR summary. Please update the summary to reflect this change or confirm its intended inclusion.Likely an incorrect or invalid review comment.
frontend/src/lib/i18n/locales/ja-JP.json (1)
44-44: Typo fix: ensure consistency across locales and code references.The key
"unauthorizedLoginSubtitle"corrects a previous typo. Please verify that:
- All other locale JSON files use this exact key.
- The application code (components or translation helper) has been updated to reference
"unauthorizedLoginSubtitle"so no lookups break at runtime.frontend/src/lib/i18n/locales/vi-VN.json (1)
49-50: Add forgotPasswordTitle with correct JSON syntaxThe
cancelTitleentry now correctly ends with a comma, and the newforgotPasswordTitlekey is appended as the last item (no trailing comma), preserving valid JSON structure and ensuring compatibility.frontend/src/lib/i18n/locales/en-US.json (2)
45-45: Approve newunauthorizedGroupsSubtitlekey
This entry clearly indicates missing group membership and follows the pattern of other unauthorized messages. Ensure you add corresponding translations in other locale files.
49-50:Details
❓ Verification inconclusive
Verify integration of new keys
You’ve appended"cancelTitle": "Cancel",and"forgotPasswordTitle": "Forgot your password?". Please confirm that your UI components reference these keys correctly and, if you’re using typed definitions (e.g., in TypeScript), update the locale key types accordingly.
You can run:
🏁 Script executed:
rg -n '"forgotPasswordTitle"' -n src rg -n '"unauthorizedGroupsSubtitle"' -n srcLength of output: 172
🏁 Script executed:
#!/bin/bash # Search for usage of the newly added i18n keys in the frontend code rg -n '"cancelTitle"' frontend/src rg -n '"forgotPasswordTitle"' frontend/src # Locate the TypeScript definitions for locale keys to ensure they include the new entries rg -n "type .*Locales" frontend/src rg -n "interface .*Locales" frontend/srcLength of output: 5270
Verify integration of new locale keys and update type definitions
I didn’t find any references to
"cancelTitle"or"forgotPasswordTitle"in your TypeScript/JS code, nor any existingLocales(or similar) type definitions for your JSON keys. Please:
- Ensure your UI components actually use these new keys where appropriate.
- If you maintain a TypeScript type or interface for your locale keys (e.g.
type Locales = keyof typeof enUS), addcancelTitleandforgotPasswordTitleto it.frontend/src/lib/i18n/locales/zh-TW.json (2)
45-45: New localization key: unauthorizedGroupsSubtitle
You've added"unauthorizedGroupsSubtitle"to convey when a user isn’t in the required groups. Ensure that the authorization flow in the UI has been updated to reference this key and display the correct message in that scenario.
49-50: Added forgotPasswordTitle with valid JSON structure
Introducing the"forgotPasswordTitle"entry alongside the trailing comma after"cancelTitle"maintains valid JSON. Confirm that the password recovery UI uses this key and that your localization tooling (e.g., Crowdin) picks it up for translation.frontend/src/lib/i18n/locales/ca-ES.json (1)
49-49: Approve trailing comma for valid JSON syntax.Adding the comma after
"cancelTitle"is correct and ensures the JSON remains valid now that a new key follows.
| "unauthorizedResourceSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to access the resource <Code>{{resource}}</Code>.", | ||
| "unaothorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.", | ||
| "unauthorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.", | ||
| "unauthorizedGroupsSubtitle": "The user with username <Code>{{username}}</Code> is not in the groups required by the resource <Code>{{resource}}</Code>.", |
There was a problem hiding this comment.
Missing Spanish translation for new key
The value for "unauthorizedGroupsSubtitle" is still in English. Please provide the appropriate Spanish localization (e.g. “El usuario con nombre de usuario … no pertenece a los grupos necesarios…”).
| "cancelTitle": "Cancel", | ||
| "forgotPasswordTitle": "Forgot your password?" |
There was a problem hiding this comment.
Localize “forgotPasswordTitle” to Spanish
The new "forgotPasswordTitle" key’s value is in English. It should be translated into Spanish (for example: “¿Olvidaste tu contraseña?”).
| "untrustedRedirectSubtitle": "You are trying to redirect to a domain that does not match your configured domain (<Code>{{domain}}</Code>). Are you sure you want to continue?", | ||
| "cancelTitle": "إلغاء" | ||
| "cancelTitle": "إلغاء", | ||
| "forgotPasswordTitle": "Forgot your password?" |
There was a problem hiding this comment.
Missing Arabic translation for forgotPasswordTitle.
The new "forgotPasswordTitle" key is using English text. Please include the Arabic equivalent to complete the locale.
| "unauthorizedResourceSubtitle": "المستخدم الذي يحمل اسم المستخدم <Code>{{username}}</Code> غير مصرح له بالوصول إلى المورد <Code>{{resource}}</Code>.", | ||
| "unaothorizedLoginSubtitle": "المستخدم الذي يحمل اسم المستخدم <Code>{{username}}</Code> غير مصرح له بتسجيل الدخول.", | ||
| "unauthorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.", | ||
| "unauthorizedGroupsSubtitle": "The user with username <Code>{{username}}</Code> is not in the groups required by the resource <Code>{{resource}}</Code>.", |
There was a problem hiding this comment.
Missing Arabic translation for unauthorizedGroupsSubtitle.
This newly added key’s value remains in English. An Arabic translation should be supplied.
| "unauthorizedTitle": "غير مرخص", | ||
| "unauthorizedResourceSubtitle": "المستخدم الذي يحمل اسم المستخدم <Code>{{username}}</Code> غير مصرح له بالوصول إلى المورد <Code>{{resource}}</Code>.", | ||
| "unaothorizedLoginSubtitle": "المستخدم الذي يحمل اسم المستخدم <Code>{{username}}</Code> غير مصرح له بتسجيل الدخول.", | ||
| "unauthorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.", |
There was a problem hiding this comment.
Missing Arabic translation for unauthorizedLoginSubtitle.
The value is currently in English in the Arabic locale file. Please provide the appropriate Arabic translation to keep localization consistent.
| "untrustedRedirectSubtitle": "You are trying to redirect to a domain that does not match your configured domain (<Code>{{domain}}</Code>). Are you sure you want to continue?", | ||
| "cancelTitle": "Cancel" | ||
| "cancelTitle": "Cancel", | ||
| "forgotPasswordTitle": "Forgot your password?" |
There was a problem hiding this comment.
Localize the 'Forgot your password?' string.
The new "forgotPasswordTitle" is still in English. Please supply the appropriate Catalan translation in this locale file.
Happy to help with the translation if needed.
| "unauthorizedResourceSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to access the resource <Code>{{resource}}</Code>.", | ||
| "unaothorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.", | ||
| "unauthorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.", | ||
| "unauthorizedGroupsSubtitle": "The user with username <Code>{{username}}</Code> is not in the groups required by the resource <Code>{{resource}}</Code>.", |
There was a problem hiding this comment.
Missing Catalan translation for new authorization message.
The added "unauthorizedGroupsSubtitle" value is currently in English. To provide a consistent experience in the ca-ES locale, please replace this with the correct Catalan translation.
Let me know if you’d like help crafting the Catalan text.
| "unauthorizedTitle": "Unauthorized", | ||
| "unauthorizedResourceSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to access the resource <Code>{{resource}}</Code>.", | ||
| "unaothorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.", | ||
| "unauthorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Ensure removal of old typo across all locale files.
The typo key "unaothorizedLoginSubtitle" has been correctly renamed here. Please verify that no other locale JSON still contains the outdated key to avoid fallback issues or missing translations.
Run this script from the repo root to confirm:
🏁 Script executed:
#!/bin/bash
# Find any remaining occurrences of the old typo in locale files
rg -l '"unaothorizedLoginSubtitle"' -g 'frontend/src/lib/i18n/locales/*.json'Length of output: 158
Fix remaining typo in locale files
The old key "unaothorizedLoginSubtitle" still exists in the following locale files and needs to be renamed to "unauthorizedLoginSubtitle" to prevent missing translations or unexpected fallbacks:
frontend/src/lib/i18n/locales/pt-BR.jsonfrontend/src/lib/i18n/locales/en.json
Suggested diff for each file:
- "unaothorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.",
+ "unauthorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "unauthorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.", | |
| # Apply in frontend/src/lib/i18n/locales/pt-BR.json | |
| - "unaothorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.", | |
| + "unauthorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.", | |
| # Apply in frontend/src/lib/i18n/locales/en.json | |
| - "unaothorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.", | |
| + "unauthorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.", |
| "unauthorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.", | ||
| "unauthorizedGroupsSubtitle": "The user with username <Code>{{username}}</Code> is not in the groups required by the resource <Code>{{resource}}</Code>.", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Correct typo and add new subtitle key for unauthorized groups
The typo fix from "unaothorizedLoginSubtitle" to "unauthorizedLoginSubtitle" is on point, and the new "unauthorizedGroupsSubtitle" key properly covers the “not in required groups” scenario. Ensure these values are localized into Romanian (they’re currently in English).
Please run a quick check to confirm all locale files include the new key:
🏁 Script executed:
#!/bin/bash
# Verify that all locale JSONs have the unauthorizedGroupsSubtitle key
rg -l '"unauthorizedGroupsSubtitle"' -g 'frontend/src/lib/i18n/locales/*.json'Length of output: 1269
Add Romanian translations for the new subtitle keys
All locale files (including ro-RO.json) now include the unauthorizedGroupsSubtitle key. However, the entries in frontend/src/lib/i18n/locales/ro-RO.json are still in English—please replace them with proper Romanian text.
• File: frontend/src/lib/i18n/locales/ro-RO.json
Lines 44–45:
- "unauthorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.",
+ "unauthorizedLoginSubtitle": "Utilizatorul cu numele de utilizator <Code>{{username}}</Code> nu este autorizat să se autentifice.",
- "unauthorizedGroupsSubtitle": "The user with username <Code>{{username}}</Code> is not in the groups required by the resource <Code>{{resource}}</Code>.",
+ "unauthorizedGroupsSubtitle": "Utilizatorul cu numele de utilizator <Code>{{username}}</Code> nu face parte din grupurile necesare pentru resursa <Code>{{resource}}</Code>."📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "unauthorizedLoginSubtitle": "The user with username <Code>{{username}}</Code> is not authorized to login.", | |
| "unauthorizedGroupsSubtitle": "The user with username <Code>{{username}}</Code> is not in the groups required by the resource <Code>{{resource}}</Code>.", | |
| "unauthorizedLoginSubtitle": "Utilizatorul cu numele de utilizator <Code>{{username}}</Code> nu este autorizat să se autentifice.", | |
| "unauthorizedGroupsSubtitle": "Utilizatorul cu numele de utilizator <Code>{{username}}</Code> nu face parte din grupurile necesare pentru resursa <Code>{{resource}}</Code>." |
| "cancelTitle": "Cancel", | ||
| "forgotPasswordTitle": "Forgot your password?" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Add forgot-password title and adjust comma placement
The added trailing comma after "cancelTitle" allows insertion of the new "forgotPasswordTitle" entry correctly. As above, please replace the English placeholder with the Romanian translation before merging.
Also validate the JSON for syntax errors:
🏁 Script executed:
python - <<'PYCODE'
import json
json.load(open('frontend/src/lib/i18n/locales/ro-RO.json'))
print("ro-RO.json is valid JSON")
PYCODELength of output: 35
Replace English placeholder with Romanian translation in ro-RO.json
We’ve confirmed the JSON is valid. Now please update the newly added entry with the correct Romanian text before merging:
• File: frontend/src/lib/i18n/locales/ro-RO.json
• Around lines 49–50:
"cancelTitle": "Cancel",
"forgotPasswordTitle": "Forgot your password?"Replace "Forgot your password?" with the appropriate Romanian translation (e.g., "Ți-ai uitat parola?").
1 participant
Summary by CodeRabbit